Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a class to hold field capabilities for one index. #51844

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Create a class to hold field capabilities for one index. #51844

merged 3 commits into from
Feb 4, 2020

Commits on Feb 4, 2020

  1. Create a class to hold field capabilities for one index. 

    Currently, the same class `FieldCapabilities` is used both to represent the
capabilities for one index, and also the merged capabilities across indices. To
help clarify the logic, this PR proposes to create a separate class
`IndexFieldCapabilities` for the capabilities in one index. The refactor will
also help when adding `source_path` information in elastic#49264, since the merged
source path field will have a different structure from the field for a single index.

Individual changes:
* Add a new class IndexFieldCapabilities.
* Remove extra constructor from FieldCapabilities.
* Combine the add and merge methods in FieldCapabilities.Builder.
    @jtibshirani
    jtibshirani committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    6a8573f View commit details
    Browse the repository at this point in the history

  2. Adjust the serialization version constant.

    @jtibshirani
    jtibshirani committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    8575f5f View commit details
    Browse the repository at this point in the history

  3. Remove calls to Map#of and Set#of.

    @jtibshirani
    jtibshirani committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    7ea9e04 View commit details
    Browse the repository at this point in the history