-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ILM policy for .ml-state* indices #52356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
ilm_for_ml_state
branch
4 times, most recently
from
February 17, 2020 12:49
d765bc7
to
121932b
Compare
Pinging @elastic/ml-core (:ml) |
przemekwitek
force-pushed
the
ilm_for_ml_state
branch
3 times, most recently
from
February 19, 2020 11:39
f5f1bf0
to
2656237
Compare
droberts195
reviewed
Feb 19, 2020
...ore/src/main/java/org/elasticsearch/xpack/core/ml/job/persistence/AnomalyDetectorsIndex.java
Outdated
Show resolved
Hide resolved
przemekwitek
force-pushed
the
ilm_for_ml_state
branch
4 times, most recently
from
February 21, 2020 14:05
2f81554
to
f6d27ff
Compare
benwtrent
reviewed
Feb 21, 2020
...ore/src/main/java/org/elasticsearch/xpack/core/ml/job/persistence/AnomalyDetectorsIndex.java
Outdated
Show resolved
Hide resolved
przemekwitek
force-pushed
the
ilm_for_ml_state
branch
2 times, most recently
from
March 3, 2020 12:39
574447e
to
fdd0b04
Compare
run elasticsearch-ci/2 |
1 similar comment
run elasticsearch-ci/2 |
przemekwitek
force-pushed
the
ilm_for_ml_state
branch
3 times, most recently
from
March 4, 2020 09:13
a4b35c4
to
95ab96e
Compare
run elasticsearch-ci/2 |
As the CI now passes this PR is ready for another look. |
droberts195
reviewed
Mar 5, 2020
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlIndexTemplateRegistry.java
Outdated
Show resolved
Hide resolved
przemekwitek
force-pushed
the
ilm_for_ml_state
branch
from
March 5, 2020 17:52
a127b4d
to
0caa02f
Compare
droberts195
approved these changes
Mar 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…001 rather than .ml-state-write
przemekwitek
force-pushed
the
ilm_for_ml_state
branch
from
March 9, 2020 09:20
0caa02f
to
93689c0
Compare
przemekwitek
added a commit
that referenced
this pull request
Mar 10, 2020
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ILM policy for
.ml-state*
indices.In case ILM plugin is not available at the time the template is being created, the ILM policy is not created.
In case only the legacy
.ml-state
index exists, the.ml-state-000001
index is created and the write alias (.ml-state-write
) is moved from.ml-state
to.ml-state-000001
so that rollover can be performed by ILM.Relates #29938