Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VotingConfiguration#of where possible #54507

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Use VotingConfiguration#of where possible #54507

merged 2 commits into from
Mar 31, 2020

Conversation

DaveCTurner
Copy link
Contributor

This resolves a longstanding TODO in the cluster coordination subsystem.

Relates #32006

@DaveCTurner
Use VotingConfiguration#of where possible
d09853a 
This resolves a longstanding TODO in the cluster coordination subsystem.

Relates elastic#32006
@DaveCTurner DaveCTurner added >non-issue :Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.0.0 v7.8.0 labels Mar 31, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Cluster Coordination)

original-brownbear
original-brownbear approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit 2073d8c into elastic:master Mar 31, 2020
@DaveCTurner
Copy link
Contributor Author

Thanks @original-brownbear

@DaveCTurner DaveCTurner deleted the 2020-03-31-voting-configuration-constructor branch March 31, 2020 18:05
DaveCTurner added a commit that referenced this pull request Apr 1, 2020
@DaveCTurner
Use VotingConfiguration#of where possible (#54507)
5e3b6ab 
This resolves a longstanding TODO in the cluster coordination subsystem.

Relates #32006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@original-brownbear original-brownbear original-brownbear approved these changes

@ywelsch ywelsch Awaiting requested review from ywelsch

Assignees
No one assigned
Labels
:Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >non-issue v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaveCTurner @elasticmachine @original-brownbear @jakelandis