Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use_field_mapping format option for docvalue fields. #55622

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Remove use_field_mapping format option for docvalue fields. #55622

merged 1 commit into from
Apr 27, 2020

Conversation

jtibshirani
Copy link
Contributor

In 7.0, we began formatting docvalue_fields by default using each field's
mapping definition. To ease the transition from 6.x, we added the format
option use_field_mapping. This parameter was deprecated in 7.0, and we can
remove it in 8.0.

@jtibshirani
Remove use_field_mapping format option for docvalue fields.
3f025bd 
In 7.0, we began formatting `docvalue_fields` by default using each field's
mapping definition. To ease the transition from 6.x, we added the format
option `use_field_mapping`. This parameter was deprecated in 7.0, and we can
remove it in 8.0.
@jtibshirani jtibshirani added >breaking :Search/Search Search-related issues that do not fall into other categories v8.0.0 labels Apr 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@cjcenizal
Copy link
Contributor

@jtibshirani Do we have docs for the use_field_mapping format option? The closest I could find was https://www.elastic.co/guide/en/elasticsearch/reference/7.x/breaking-changes-7.0.html#_doc_value_fields_default_format.

@jtibshirani
Copy link
Contributor Author

I caught up with @cjcenizal offline -- we don't seem to have other docs.

jimczi
jimczi approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtibshirani jtibshirani merged commit 724e24d into elastic:master Apr 27, 2020
@jtibshirani jtibshirani deleted the doc-values-format branch April 27, 2020 19:42
@jakelandis jakelandis mentioned this pull request Feb 22, 2021
Closed
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Jun 22, 2021
@pgomulka
[Rest Api Compatibility] Ignore use_field_mapping option for docvalue
019291a 
previously removed in elastic#55622 use_field_mapping option can be used on doc
value format under rest api compatibility.
The value itself is ignored (replaced with null) as it is a default
behaviour to use field mapping format.
@pgomulka pgomulka mentioned this pull request Jun 22, 2021
Merged
pgomulka added a commit that referenced this pull request Jun 24, 2021
@pgomulka
[Rest Api Compatibility] Ignore use_field_mapping option for docvalue (…
dd7d37c 
…#74435)

previously removed in #55622 use_field_mapping option can be used on doc
value format under rest api compatibility.
The value itself is ignored (replaced with null) as it is a default
behaviour to use field mapping format.

relates #51816
@masseyke masseyke mentioned this pull request Aug 9, 2021
Closed
80 tasks
@hkulekci hkulekci mentioned this pull request Feb 17, 2022
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimczi jimczi jimczi approved these changes

Assignees
No one assigned
Labels
>breaking :Search/Search Search-related issues that do not fall into other categories v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jtibshirani @elasticmachine @cjcenizal @jimczi @jakelandis