Add read privileges for observability-annotations for apm_user #58530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
approved these changes
Jun 25, 2020
|
Lgtm but you'll need someone from the ES side to 👍 this too. |
tvernum
reviewed
Jun 29, 2020
|
@tvernum I've added a test - LMK if that's good enough. |
tvernum
added
:Security/Authentication
|
Pinging @elastic/es-security (:Security/Authentication) |
|
@dgieselaar I added labels, including version labels. Can you confirm that they reflect the releases you intend to target? |
tvernum
added
:Security/Authorization
|
@tvernum we'd also like to get this in for 7.8.1, is that possible? |
|
That's fine. I've updated the labels. |
|
thanks @tvernum! Ok for me to merge & backport? |
|
Yes, go ahead. |
dgieselaar
changed the title
This was referenced Jun 30, 2020
dgieselaar
added a commit
to dgieselaar/elasticsearch
that referenced
this pull request
Jun 30, 2020
dgieselaar
added a commit
that referenced
this pull request
Jul 1, 2020
dgieselaar
added a commit
that referenced
this pull request
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes elastic/kibana#69642. See also elastic/kibana#69881.
In elastic/kibana#64796, we added support for annotations (and a public API to create them) in the APM UI. Annotations are stored (by default, but configurable) in
observability-annotations. We've documented that users need access to theobservability-annotationsindex to create annotations via the API, but neglected to do so for using the UI.To ensure a great out-of-the-box experience we'd like to add read privileges for this index by default.