Add term query for keyword script fields #59372
Conversation
This adds what I think is just about the simplest possible `term` query implementation for `keyword` script fields and wires it into the field mapper that we build for them.
| @Override | ||
| public float matchCost() { | ||
| // TODO we don't have a good way of estimating the complexity of the script so we just go with 9000 | ||
| return 9000f; |
There was a problem hiding this comment.
did we say that approximation.cost() was not good here?
There was a problem hiding this comment.
Yeah, Lucene documents this as "An estimate of the expected cost to determine that a single document". So multiplying by the cost of the approximation don't feel right. 9000 is kind of bogus too, but maybe less so.
There was a problem hiding this comment.
let's ask @jpountz what he thinks. I thought I remembered discussing with him that the cost could be the cost of the approximation but I may be wrong.
There was a problem hiding this comment.
this should not block merging the PR, we can always update the cost later.
There was a problem hiding this comment.
+1 a high constant looks good to me
javanna
added
the
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
This adds what I think is just about the simplest possible
termqueryimplementation for
keywordscript fields and wires it into the fieldmapper that we build for them.
Relates to #59332