EQL: Fix async EQL Rest test #59556
Merged
EQL: Fix async EQL Rest test #59556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, we cannot guarantee that the execution will be truly async even with 0ms timeout since we cannot block the execution. So, we need to modify the test to work in both async and non-async mode. Closes elastic#59416
imotov
added
>test
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
elasticmachine
added
the
Team:QL (Deprecated)
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
|
@elasticmachine update branch |
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Jul 15, 2020
Unfortunately, we cannot guarantee that the execution will be truly async even with 0ms timeout since we cannot block the execution. So, we need to modify the test to work in both async and non-async mode. Closes elastic#59416
imotov
added a commit
that referenced
this pull request
Jul 15, 2020
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Jul 15, 2020
Unfortunately, we cannot guarantee that the execution will be truly async even with 0ms timeout since we cannot block the execution. So, we need to modify the test to work in both async and non-async mode. Closes elastic#59416
imotov
added a commit
that referenced
this pull request
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, we cannot guarantee that the execution will be truly
async even with 0ms timeout since we cannot block the execution. So, we need
to modify the test to work in both async and non-async mode.
Closes #59416