Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double script fields #59933

Merged
merged 8 commits into from
Jul 21, 2020
Merged

Add double script fields #59933

merged 8 commits into from
Jul 21, 2020

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jul 20, 2020

This adds support for double typed script fields.

@nik9000
Add double script fields
b7a1c81 
This adds support for `double` typed `script` fields.
@nik9000 nik9000 added the :Search/Search Search-related issues that do not fall into other categories label Jul 20, 2020
@nik9000 nik9000 requested a review from javanna July 20, 2020 21:06
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 20, 2020
javanna
javanna approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of suggestions for possible later improvements, LGTM though

.../src/main/java/org/elasticsearch/xpack/runtimefields/mapper/ScriptDoubleMappedFieldType.java Show resolved Hide resolved
x-pack/plugin/src/test/resources/rest-api-spec/test/runtime_fields/30_double.yml Show resolved Hide resolved
...test/java/org/elasticsearch/xpack/runtimefields/mapper/ScriptDoubleMappedFieldTypeTests.java Outdated Show resolved Hide resolved
@javanna javanna mentioned this pull request Jul 21, 2020
Closed
30 tasks
@nik9000 nik9000 merged commit 8bddd84 into elastic:feature/runtime_fields Jul 21, 2020
@nik9000
Copy link
Member Author

nik9000 commented Jul 21, 2020

Thanks @javanna !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees
No one assigned
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nik9000 @elasticmachine @javanna