Error on bad shape relations in runtime fields #60463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most core types throw back an error if the `relation` on a `range` query is `disjoint`. This make runtime fields do the same.
nik9000
added
the
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
nik9000
commented
Jul 30, 2020
| ) { | ||
| if (relation == ShapeRelation.DISJOINT) { | ||
| String message = "Field [%s] of type [%s] with runtime type [%s] does not support DISJOINT ranges"; | ||
| throw new IllegalArgumentException(String.format(Locale.ROOT, message, name(), typeName(), runtimeType())); |
There was a problem hiding this comment.
I went with this rather funny way of writing the message because it made the formatter happy. Most of the other options I tried caused the formatter to split the message over so many lines it wasn't readable. I don't generally like String.format for these but here it looks best, I think.
30 tasks
javanna
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most core types throw back an error if the
relationon arangequeryis
disjoint. This make runtime fields do the same.Relates to #59332