Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fix wrong result when executing bulk requests with and without pipeline #61777

Conversation

danhermann
Copy link
Contributor

Closes #60437 .

When executing bulk api, if one request has no ingest pipeline and others have ingest pipeline, then the response is not correct, that's because in IngestService#executeBulkRequest() method, the cursor i doesn't move to next if the request has no ingest pipeline.

The main changes are:

  1. fix the bug in IngestService#executeBulkRequest().
  2. add some unit tests.
  3. add a yaml test.

Backport of #60818

@danhermann danhermann added >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP backport v7.10.0 labels Sep 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Sep 1, 2020
@danhermann danhermann merged commit 88a448f into elastic:7.x Sep 1, 2020
@danhermann danhermann deleted the backport_7x_60818_fix_bulk_req_with_pipelines branch September 1, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants