Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate REST access to System Indices (#63274) (Original #60945) #63274

Merged
merged 44 commits into from
Oct 6, 2020
Merged

Deprecate REST access to System Indices (#63274) (Original #60945) #63274

merged 44 commits into from
Oct 6, 2020

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Oct 5, 2020

Backport of #60945.

@gwbrown gwbrown changed the title Deprecate REST access to System Indices [7.x Backport] Deprecate REST access to System Indices Oct 5, 2020
@gwbrown
Specify number of shards in SystemIndicesUpgradeIT to avoid warning (…
cb2be68 
…got lost in merge)
@gwbrown
Refresh no longer allow system index access by default
9049662
@gwbrown
Remove unnecessary log line
6f31039
@gwbrown
Don't create a new threadcontext, we already have one
ff99aa4
@gwbrown
Don't need to take ThreadContext as a param in dispatchRequest
7d4e193
@gwbrown
Javadoc for isSystemIndexAccessAllowed
716750a
@gwbrown
Deprecation logger doesn't need to be public
6bc4944
@gwbrown
Doc fix per review
58fb00e
@gwbrown
Allow deprecation warning for refreshing all indices
80b5b38
@gwbrown
Allow warnings on refresh in reindex YAML tests
1d4b965
@gwbrown
Properly populate client in RestControllerTests now that it's actuall…
a103022 
…y used
@gwbrown
Stash context in RestSubmitAsyncSearchActionTests so the same headers…
4f420ac 
… don't get added multiple times
@gwbrown
Handle more _refresh warnings
0f8442c
@gwbrown
RequestOptions builder compilation fix
b5bc29b
@gwbrown
Unused import
9d2fab7
@gwbrown
YAML skip: features: warnings block
a3e45e0
@gwbrown
Address _refresh warnings in yaml tests
312d48e
@gwbrown
Warn when accessing aliases with names reserved for system indices
ca43d93
@gwbrown
Suppress warnings when X-elastic-product-origin header is present
2f756a5
@gwbrown
Unused import
93054c1
@gwbrown
EMPTY_MAP -> emptyMap()
936dae7
@gwbrown
Re-apply some changes to RestSubmitAsyncSearchActionTests accidentall…
4c6bf67 
…y lost in merge
@gwbrown
Set verifier function to no-op in tests that don't use it
f651f9c
@gwbrown
Merge branch '7.x' into backport/7.x/si/protection-header
2da83a1
@gwbrown
Invert incorrect header check
af2feaf
@gwbrown
Add comment about header
36b7bd6
@gwbrown
YAML syntax is THE WORST
eff30e6
@gwbrown gwbrown marked this pull request as ready for review October 6, 2020 16:23
@gwbrown gwbrown requested a review from jaymode October 6, 2020 16:23
jaymode
jaymode approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwbrown gwbrown changed the title [7.x Backport] Deprecate REST access to System Indices Deprecate REST access to System Indices (#63274) (Original #60945) Oct 6, 2020
@gwbrown gwbrown merged commit 5c8b066 into elastic:7.x Oct 6, 2020
@gwbrown gwbrown deleted the backport/7.x/si/protection-header branch October 6, 2020 19:41
@gwbrown gwbrown added the v7.10.0 label Oct 7, 2020
@dblock dblock mentioned this pull request Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymode jaymode jaymode approved these changes

Assignees
No one assigned
Labels
backport v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwbrown @jaymode