Add helper functions for ByteSizeValues of a given unit #63679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-features (:Core/Features/Features) |
elasticmachine
added
the
Team:Data Management
|
run elasticsearch-ci/1 |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Oct 14, 2020
As a developer that periodically worries about absolute sizes of bytes, I love our good ByteSizeValue abstractions + and the unit sizes. But, I find the pattern `new ByteSizeValue(<some long>, <some unit>).getBytes()` frustrating. This commit adds some simple convenience methods for each byte unit and constructing a ByteSizeValue of the given size for that unit.
benwtrent
added a commit
that referenced
this pull request
Oct 14, 2020
) As a developer that periodically worries about absolute sizes of bytes, I love our good ByteSizeValue abstractions + and the unit sizes. But, I find the pattern `new ByteSizeValue(<some long>, <some unit>).getBytes()` frustrating. This commit adds some simple convenience methods for each byte unit and constructing a ByteSizeValue of the given size for that unit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a developer that periodically worries about absolute sizes of bytes, I love our good ByteSizeValue abstractions + and the unit sizes.
But, I find the pattern
new ByteSizeValue(<some long>, <some unit>).getBytes()frustrating.This commit adds some simple convenience methods for each byte unit and constructing a ByteSizeValue of the given size for that unit.