Preserve backing index ordering for data streams #63749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
added
>bug
:Data Management/Indices APIs
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
elasticmachine
added
the
Team:Data Management
probakowski
approved these changes
Oct 15, 2020
Comment on lines
176
to
178
| backingIndices.add(createIndexMetadata("not-in-order-2", true)); | ||
| backingIndices.add(createIndexMetadata("not-in-order-1", true)); | ||
| backingIndices.add(createIndexMetadata(DataStream.getDefaultBackingIndexName(dataStreamName, 3), true)); |
There was a problem hiding this comment.
Suggested change
| backingIndices.add(createIndexMetadata("not-in-order-2", true)); | |
| backingIndices.add(createIndexMetadata("not-in-order-1", true)); | |
| backingIndices.add(createIndexMetadata(DataStream.getDefaultBackingIndexName(dataStreamName, 3), true)); | |
| String[] names = new String[]{"not-in-order-2", "not-in-order-1", DataStream.getDefaultBackingIndexName(dataStreamName, 3)}; | |
| List<IndexMetadata> backingIndices = Arrays.stream(names).map(n -> createIndexMetadata(n, true)).collect(Collectors.toList()); |
Comment on lines
194
to
197
| assertThat(dataStreams.get(0).getBackingIndices().length, equalTo(3)); | ||
| assertThat(dataStreams.get(0).getBackingIndices()[0], equalTo(backingIndices.get(0).getIndex().getName())); | ||
| assertThat(dataStreams.get(0).getBackingIndices()[1], equalTo(backingIndices.get(1).getIndex().getName())); | ||
| assertThat(dataStreams.get(0).getBackingIndices()[2], equalTo(backingIndices.get(2).getIndex().getName())); |
There was a problem hiding this comment.
Suggested change
| assertThat(dataStreams.get(0).getBackingIndices().length, equalTo(3)); | |
| assertThat(dataStreams.get(0).getBackingIndices()[0], equalTo(backingIndices.get(0).getIndex().getName())); | |
| assertThat(dataStreams.get(0).getBackingIndices()[1], equalTo(backingIndices.get(1).getIndex().getName())); | |
| assertThat(dataStreams.get(0).getBackingIndices()[2], equalTo(backingIndices.get(2).getIndex().getName())); | |
| assertThat(dataStreams.get(0).getBackingIndices(), arrayContaining(names)); |
|
Thanks, @probakowski! I took your suggestions for simplifying the test. |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Oct 19, 2020
danhermann
added a commit
that referenced
this pull request
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolve index API incorrectly sorts the backing indices returned for data streams. The backing indices on a data stream are an ordered list in which the last index is always the write index so sorting them may produce incorrect results once migration of existing indices to data streams is permitted.