Assign id to searcher using ids of segments #66668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
:Distributed/Engine
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Dec 21, 2020
...ernalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/RetrySearchIntegTests.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/elasticsearch/indices/state/CloseIndexIT.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/engine/ReadOnlyEngineTests.java
Outdated
Show resolved
Hide resolved
dnhatn
changed the title
@elasticmachine run elasticsearch-ci/1 |
|
Thanks Henning for reviewing. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Dec 21, 2020
The commit id introduced in elastic#63963 does not work well with searchable snapshots as we create a new index commit when restoring from snapshots. This change revises an approach that generates an id using the ids of the segments of an index commit. Relates elastic#63963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit id introduced in #63963 does not work well with searchable snapshots as we create a new index commit when restoring from snapshots. This change revises the previous approach that generates a commit id using the ids of the segments of an index commit.
Relates #63963