Add ML associated indices #69492
Merged
Add ML associated indices #69492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These somehow got dropped from the initial Feature States PR, so this commit adds them again.
|
Pinging @elastic/ml-core (Team:ML) |
droberts195
reviewed
Feb 24, 2021
| @@ -1217,6 +1218,11 @@ public static SystemIndexDescriptor getInferenceIndexSecurityDescriptor() { | |||
| .build(); | |||
| } | |||
|
|
|||
| @Override | |||
| public Collection<String> getAssociatedIndexPatterns() { | |||
| return List.of(RESULTS_INDEX_PREFIX + "*", STATE_INDEX_PREFIX + "*", ".ml-notifications*", ".ml-annotations*"); | |||
|
@elasticmachine update branch |
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Mar 1, 2021
ML's associated indices somehow got dropped from the initial Feature States PR, so this commit adds them again.
This was referenced Mar 1, 2021
gwbrown
added a commit
that referenced
this pull request
Mar 1, 2021
ML's associated indices somehow got dropped from the initial Feature States PR, so this commit adds them again.
gwbrown
added a commit
that referenced
this pull request
Mar 1, 2021
ML's associated indices somehow got dropped from the initial Feature States PR, so this commit adds them again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These somehow got dropped from the initial Feature States PR, so this
commit adds them again.
Note for reviewers: If you are not familiar with associated indices, they are new as of #63513. See this comment:
elasticsearch/server/src/main/java/org/elasticsearch/plugins/SystemIndexPlugin.java
Lines 43 to 48 in 4e429af
They are currently only used for ensuring all of a feature's indices are included in snapshots that specify they should include that feature's state - that is, if a plugin's system indices are included in a snapshot, that plugin's associated indices will be as well. They will also be used for the upcoming reset API (see #69469).