-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ignore_unmapped
work for sorting cross-index queries.
#7039
Conversation
@@ -36,7 +36,7 @@ | |||
|
|||
private Object missing; | |||
|
|||
private Boolean ignoreUnmapped; | |||
private Object ignoreUnmapped; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was wondering why this is an Object
rather then a String
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a setter with a String parameter but there was already also one with a boolean parameter. So I made the variable an object internally so that it can be either a Boolean or a String.
|
Mapper.Builder<?, ?> builder = typeParser.parse(fieldName, ImmutableMap.<String, Object>of(), parserContext); | ||
Settings indexSettings = context.indexShard().indexService().settingsService().getSettings(); | ||
BuilderContext builderContext = new BuilderContext(indexSettings, new ContentPath(1)); | ||
fieldMapper = (FieldMapper<?>) builder.build(builderContext); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we maybe share these on an index level, instead of doing the whole build process over and over? just a set of static (index level) common types?
@areek @markharwood @kimchy Pushed new commits to address your concerns. |
LGTM |
ignore_unmapped
work for cross-index queries.ignore_unmapped
work for sorting cross-index queries.
Close #2255