Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Mark freeze API as deprecated #72946

Merged

Conversation

danhermann
Copy link
Contributor

@danhermann danhermann commented May 11, 2021

@danhermann danhermann added >docs General docs changes :Data Management/Indices APIs APIs to create and manage indices and templates >deprecation v8.0.0 v7.14.0 labels May 11, 2021
@danhermann danhermann requested a review from jrodewig May 11, 2021 16:41
@danhermann danhermann marked this pull request as ready for review May 11, 2021 16:41
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels May 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We'll also need to figure out how to handle the frozen indices overview + best practices:
https://elasticsearch_72946.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/frozen-indices.html

We can likely just remove them and add redirects. I can handle that as a separate PR, but let me know your thoughts!

@@ -6,6 +6,8 @@
<titleabbrev>Freeze index</titleabbrev>
++++

deprecated::[8.0, Frozen indices are no longer useful due to https://www.elastic.co/blog/significantly-decrease-your-elasticsearch-heap-memory-usage[recent improvements in heap memory utilization]]
Copy link
Contributor

@jrodewig jrodewig May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits: I think the deprecation release is actually 7.14. I'd also use usage instead of utilization. Adds a period.

Suggested change
deprecated::[8.0, Frozen indices are no longer useful due to https://www.elastic.co/blog/significantly-decrease-your-elasticsearch-heap-memory-usage[recent improvements in heap memory utilization]]
deprecated::[7.14, Frozen indices are no longer useful due to https://www.elastic.co/blog/significantly-decrease-your-elasticsearch-heap-memory-usage[recent improvements in heap memory usage].]

@danhermann
Copy link
Contributor Author

Thanks, @jrodewig!

We'll also need to figure out how to handle the frozen indices overview + best practices:
https://elasticsearch_72946.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/frozen-indices.html

We can likely just remove them and add redirects. I can handle that as a separate PR, but let me know your thoughts!

That sounds good to me.

Nits: I think the deprecation release is actually 7.14.

The deprecation release is 7.14. I know that for version references in code, we update that after backporting, but is it different for docs?

@jrodewig
Copy link
Contributor

The deprecation release is 7.14. I know that for version references in code, we update that after backporting, but is it different for docs?

That's typically true in the docs too, but deprecation notes are an exception. The version in the deprecation admon is the release in which we first deprecated the feature.

@danhermann danhermann merged commit d0fd686 into elastic:master May 11, 2021
@danhermann danhermann deleted the 70192_mark_freeze_endpoint_as_deprecated branch May 11, 2021 19:27
danhermann added a commit to danhermann/elasticsearch that referenced this pull request May 11, 2021
jrodewig added a commit to elastic/stack-docs that referenced this pull request May 12, 2021
elastic/elasticsearch#72946 marks the freeze API
as deprecated. This removes a couple of glossary terms related to frozen
indices.

Relates to elastic/elasticsearch#72990.
jrodewig added a commit that referenced this pull request May 12, 2021
Changes:

* Removes and adds redirects for the frozen indices [overview][0], [best
  practices][1], [search][2], and [monitoring][3] pages.
* Removes glossary terms related to frozen indices.
* Updates several xrefs to point to the freeze index API docs.

Relates to #72946 and #70192.

[0]: https://www.elastic.co/guide/en/elasticsearch/reference/7.12/frozen-indices.html
[1]: https://www.elastic.co/guide/en/elasticsearch/reference/master/best_practices.html
[2]: https://www.elastic.co/guide/en/elasticsearch/reference/master/searching_a_frozen_index.html
[3]: https://www.elastic.co/guide/en/elasticsearch/reference/master/monitoring_frozen_indices.html
jrodewig added a commit that referenced this pull request May 12, 2021
…3001)

Changes:

* Removes and adds redirects for the frozen indices [overview][0], [best
  practices][1], [search][2], and [monitoring][3] pages.
* Removes glossary terms related to frozen indices.
* Updates several xrefs to point to the freeze index API docs.

Relates to #72946 and #70192.

[0]: https://www.elastic.co/guide/en/elasticsearch/reference/7.12/frozen-indices.html
[1]: https://www.elastic.co/guide/en/elasticsearch/reference/master/best_practices.html
[2]: https://www.elastic.co/guide/en/elasticsearch/reference/master/searching_a_frozen_index.html
[3]: https://www.elastic.co/guide/en/elasticsearch/reference/master/monitoring_frozen_indices.html
2lambda123 pushed a commit to 2lambda123/elastic-elasticsearch that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >deprecation >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants