Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate encrypted repository plugin integ tests #72959

Merged
merged 1 commit into from
May 12, 2021

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented May 11, 2021

The encrypted repository module supports encryption with existing
repository plugins. Currently the integration tests with these plugins
pull in all of the plugins into the same test classpath. That can cause
problems when the dependencies of those repositories need to differ.
This commit splits the tests into separate qa subprojects.

The encrypted repository module supports encryption with existing
repository plugins. Currently the integration tests with these plugins
pull in all of the plugins into the same test classpath. That can cause
problems when the dependencies of those repositories need to differ.
This commit splits the tests into separate qa subprojects.
@rjernst rjernst added >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels May 11, 2021
@rjernst rjernst requested a review from mark-vieira May 11, 2021 19:42
@elasticmachine elasticmachine added Team:Distributed Meta label for distributed team Team:Delivery Meta label for Delivery team labels May 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the parent :qa project build file strictly required? I don't think it is. If not let's delete it. Even though it's empty, we still have to compile it.


dependencies {
internalClusterTestImplementation testArtifact(project(':plugins:repository-azure'), 'internalClusterTest')
internalClusterTestImplementation testArtifact(project(':x-pack:plugin:repository-encrypted'), 'test')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, in this scenario you can omit the test parameter as this is the default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it for clarity, but feel free to remove it when I'm not looking

@rjernst
Copy link
Member Author

rjernst commented May 12, 2021

Is the parent :qa project build file strictly required?

I believe it is necessary. The way we build out all of x-pack in settings.gradle is through recursively finding build.gradle files. Otherwise we wouldn't know qa was supposed to be a subproject.

@rjernst rjernst merged commit 0937c3f into elastic:master May 12, 2021
@mark-vieira
Copy link
Contributor

I believe it is necessary. The way we build out all of x-pack in settings.gradle is through recursively finding build.gradle files. Otherwise we wouldn't know qa was supposed to be a subproject.

Roger that.

@rjernst rjernst deleted the azure_upgrade3 branch May 12, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Delivery Meta label for Delivery team Team:Distributed Meta label for distributed team >test Issues or PRs that are addressing/adding tests v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants