[7.13] More precise total data set size verification in FrozenSearchableSnapshotsIntegTests #73455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shotsIntegTests (elastic#73243) In elastic#70625 we added the total data set size of shards to the Indices Stats API and we enhanced the test testCreateAndRestorePartialSearchableSnapshot to also verify the correctness of this data set size. Because restoring a searchable snapshot shard creates a new in-memory segment size, the verification of the data set size was implemented in an approximative fashion: between the expected size and twice the expected size. This approximation sometimes fails for shards that have no documents indexed (see elastic#73194). This commit changes the test so that it now verifies the exact data set size returned by the Indices Stats API, which should be the sum of the original expected size of the snapshotted size + the length of the extra segment file in memory. Closes elastic#73194
tlrx
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #70625 we added the total data set size of shards
to the Indices Stats API and we enhanced the test
testCreateAndRestorePartialSearchableSnapshot to
also verify the correctness of this data set size.
Because restoring a searchable snapshot shard
creates a new in-memory segment size, the
verification of the data set size was implemented
in an approximative fashion: between the
expected size and twice the expected size. This
approximation sometimes fails for shards that
have no documents indexed (see #73194).
This commit changes the test so that it now
verifies the exact data set size returned by the
Indices Stats API, which should be the sum of
the original expected size of the snapshotted
size + the length of the extra segment file in
memory.
Closes #73194
Backport of #73243