Allow some Repository Settings to be Updated Dynamically (#72543) #74052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit serves two purposes. For one, we need the ability to dynamically update a repository setting for the encrypted repository work. Also, this allows dynamically updating repository rate limits while snapshots are in progress. This has often been an issue in the past where a long running snapshot made progress over a long period of time already but is going too slowly with the current rate limit. This left no good options, either throw away the existing partly done snapshot's work and recreate the repo with a higher rate limit to speed things up or wait for a long time with the current rate limit. With this change the rate limit can simply be increased while a snapshot or restore is running and will take effect imidiately.
original-brownbear
added
:Distributed/Snapshot/Restore
|
Pinging @elastic/es-distributed (Team:Distributed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit serves two purposes. For one, we need the ability to dynamically
update a repository setting for the encrypted repository work.
Also, this allows dynamically updating repository rate limits while snapshots are
in progress. This has often been an issue in the past where a long running snapshot
made progress over a long period of time already but is going too slowly with the
current rate limit. This left no good options, either throw away the existing
partly done snapshot's work and recreate the repo with a higher rate limit to speed
things up or wait for a long time with the current rate limit.
With this change the rate limit can simply be increased while a snapshot or restore
is running and will take effect immediately.
backport of #72543