-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Next Field in Paginated GetSnapshots Response #74236
Merged
original-brownbear
merged 16 commits into
elastic:master
from
original-brownbear:next-field-get-snapshots
Jun 28, 2021
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0092197
Introduce Next Field in Paginated GetSnapshots Response
original-brownbear 6f41fa6
cleanup docs
original-brownbear 622b25b
duration isn't always 0 on ci
original-brownbear 0f9aad3
Merge remote-tracking branch 'elastic/master' into next-field-get-sna…
original-brownbear e178f43
Merge remote-tracking branch 'elastic/master' into next-field-get-sna…
original-brownbear d3b362b
fix test
original-brownbear 332cbfb
next field correct in all cases
original-brownbear 60264aa
Merge remote-tracking branch 'elastic/master' into next-field-get-sna…
original-brownbear 8a829d1
base64 encode param
original-brownbear 59ac817
docs + repo tiebraker
original-brownbear 70b957f
Merge remote-tracking branch 'elastic/master' into next-field-get-sna…
original-brownbear 27cf07e
fix param doc stest
original-brownbear 4da55ff
Merge remote-tracking branch 'elastic/master' into next-field-get-sna…
original-brownbear 72f29fe
URL-encode base 64
original-brownbear 025116d
Merge remote-tracking branch 'elastic/master' into next-field-get-sna…
original-brownbear 497333c
rename
original-brownbear File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is worth spending a few lines explaining that the underlying list can change and how pagination works in case of deletes and additions during pagination (i.e., you are sure to not miss any that were in the list originally and have not been deleted during pagination and you may see snapshots added during pagination).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ added a few lines on this