Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust freeze endpoint deprecation version #74705

Closed

Conversation

joegallo
Copy link
Contributor

Followup to #72618

The _freeze endpoint is deprecated in 7.x and will only be available via rest api compatibility in 8.x, while the _unfreeze endpoint is deprecated in both 7.x and 8.x and will only be available via rest api compatibility in 9.x.

and will only be available via rest api compatibility in 8.x, while
the _unfreeze endpoint is deprecated in both 7.x and 8.x and will only
be available via rest api compatibility in 9.x.
@joegallo joegallo added the :Data Management/Indices APIs APIs to create and manage indices and templates label Jun 29, 2021
@joegallo joegallo requested a review from danhermann June 29, 2021 15:03
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this, @joegallo!

joegallo added a commit to danhermann/elasticsearch that referenced this pull request Jun 29, 2021
Kindof a sneaky backport-by-commit of part of elastic#74705
@joegallo
Copy link
Contributor Author

This PR actually gets a little more interesting the more I look at it. The amount of failing tests here and my recollection of where we intend to go with the behavior on 8.x for the _freeze API leads me to believe we need to do just a little more discussion on it. I'll bring it up with the Rest API Compatibility folks and see it through.

@joegallo joegallo self-assigned this Jun 29, 2021
@jakelandis
Copy link
Contributor

related: #70192 (comment)

@joegallo
Copy link
Contributor Author

joegallo commented Oct 25, 2021

I'll replace this with a different PR now that #78918 is going to pull the _freeze endpoint.

edit: that'd be #79861

@joegallo joegallo closed this Oct 25, 2021
@joegallo joegallo deleted the adjust-freeze-endpoint-deprecation branch October 25, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants