Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL Blocking IntegTests #75083

Merged

Conversation

original-brownbear
Copy link
Member

@original-brownbear original-brownbear commented Jul 7, 2021

We have a number of failures in these tests due to #75022
which makes the field caps transport action fork to the management pool.
-> we have to always fork in this test now to not block the management pool.

Example failure https://gradle-enterprise.elastic.co/s/knxednfbfn67m/tests/:x-pack:plugin:eql:internalClusterTest/org.elasticsearch.xpack.eql.action.RestEqlCancellationIT/testRestCancellation?top-execution=1

We have a number of failures in these tests due to elastic#75022
which makes the field caps transport action fork to the management pool.
-> we have to always fork in this test now to not block the management pool.
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Analytics/SQL SQL querying v8.0.0 v7.15.0 labels Jul 7, 2021
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Jul 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@bpintea
Copy link
Contributor

bpintea commented Jul 7, 2021

Would we have to apply this to EQL's twin abstract test case?

Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Member Author

@bpintea thanks! probably, I'll look into EQL right away, I'll merge this now though to unblock tests for people, EQL seems to not be failing for some reason.

@original-brownbear original-brownbear merged commit fef1874 into elastic:master Jul 7, 2021
@original-brownbear original-brownbear deleted the fix-sql-block-tests branch July 7, 2021 18:32
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 7, 2021
original-brownbear added a commit that referenced this pull request Jul 7, 2021
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 8, 2021
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 8, 2021
We have a number of failures in these tests due to elastic#75022
which makes the field caps transport action fork to the management pool.
-> we have to always fork in this test now to not block the management pool.
@original-brownbear original-brownbear restored the fix-sql-block-tests branch April 18, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants