Use a real out of memory error in die with dignity #77039
Merged
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today when testing dying with dignity, we simply throw an OutOfMemoryError. We know this should not get caught by any intermediate code and end up in the uncaught exception handler. This allows us to test that this exception handler is able to successfully kill the VM. However, it is on the table to no longer use the uncaught exception handler, but instead the built-in support for ExitOnOutOfMemoryError. A fake OutOfMemoryError would not be processed by this handler, so to prepare the way, we switch to using a real OutOfMemoryError.
jasontedor
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
henningandersen
approved these changes
Aug 31, 2021
| @@ -62,7 +62,7 @@ public void testDieWithDignity() throws Exception { | |||
| ".*ElasticsearchUncaughtExceptionHandler.*", | |||
| ".*javaRestTest-0.*", | |||
| ".*fatal error in thread \\[Thread-\\d+\\], exiting.*", | |||
| ".*java.lang.OutOfMemoryError: die with dignity.*" | |||
| ".*java.lang.OutOfMemoryError: Requested array size exceeds VM limit.*" | |||
There was a problem hiding this comment.
This leaks jvm implementation into our tests. I am not really against that, but perhaps we can add a comment to remove the text from matching if it fails?
jasontedor
added a commit
that referenced
this pull request
Sep 1, 2021
Today when testing dying with dignity, we simply throw an OutOfMemoryError. We know this should not get caught by any intermediate code and end up in the uncaught exception handler. This allows us to test that this exception handler is able to successfully kill the VM. However, it is on the table to no longer use the uncaught exception handler, but instead the built-in support for ExitOnOutOfMemoryError. A fake OutOfMemoryError would not be processed by this handler, so to prepare the way, we switch to using a real OutOfMemoryError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when testing dying with dignity, we simply throw an
OutOfMemoryError. We know this should not get caught by any intermediate code and end up in the uncaught exception handler. This allows us to test that this exception handler is able to successfully kill the VM. However, it is on the table to no longer use the uncaught exception handler, but instead the built-in support forExitOnOutOfMemoryError. A fakeOutOfMemoryErrorwould not be processed by this handler, so to prepare the way, we switch to using a realOutOfMemoryError.Relates #71542