Deprecate ignore_throttled parameter #77479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
force-pushed
the
deprecate_ignore_throttled
branch
from
6f1e18d
to
29f334f
Compare
12 tasks
martijnvg
force-pushed
the
deprecate_ignore_throttled
branch
3 times, most recently
from
f0d26e8
to
41acd04
Compare
Frozen indices are deprecated, which will make ignore_throttled obsolete.
Some changes to HLRC HLRC and related tests were required in order to deprecate ignore_throttled parameter:
* Change HLRC request classes to set indices options initial value to null.
This avoids sending the ignore_throttled parameter (and other indices options parameters)
and therefore avoids the depracation warning header in the response. All these
request classes had the indices options set to what is the defaukt in the corresponding
action request class. So sending these indices options params was a noop, which is the same
as not sending indices options parameters, which is what this change does.
* For transport action request classes that are reused in the HLRC as request class,
change the corresponding hlrc request converter to only send indices options params
if the indices options are different than what the default is.
* For tests that use a non default indices options, allow 'ignore_throttled is deprecated'
warning.
Other changes:
* A number of tests have been changed to allowed warning header for deprecated ignore_throttled parameter.
* Some rest v7 compat yaml tests are temporary muted, but will be unmuted once this
change has been backported.
Relates to elastic#70192
martijnvg
force-pushed
the
deprecate_ignore_throttled
branch
from
41acd04
to
e619a91
Compare
martijnvg
added
:Data Management/Indices APIs
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
danhermann
approved these changes
Sep 15, 2021
server/src/main/java/org/elasticsearch/action/support/IndicesOptions.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample |
1 similar comment
|
@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 16, 2021
Backporting elastic#77479 to 7.x branch. Frozen indices are deprecated, which will make ignore_throttled obsolete. Some changes to HLRC HLRC and related tests were required in order to deprecate ignore_throttled parameter: * Change HLRC request classes to set indices options initial value to null. This avoids sending the ignore_throttled parameter (and other indices options parameters) and therefore avoids the depracation warning header in the response. All these request classes had the indices options set to what is the defaukt in the corresponding action request class. So sending these indices options params was a noop, which is the same as not sending indices options parameters, which is what this change does. * For transport action request classes that are reused in the HLRC as request class, change the corresponding hlrc request converter to only send indices options params if the indices options are different than what the default is. * For tests that use a non default indices options, allow 'ignore_throttled is deprecated' warning. Other changes: * A number of tests have been changed to allowed warning header for deprecated ignore_throttled parameter. * Some rest v7 compat yaml tests are temporary muted, but will be unmuted once this change has been backported. Relates to elastic#70192
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
* Deprecate ignore_throttled parameter Backporting #77479 to 7.x branch. Frozen indices are deprecated, which will make ignore_throttled obsolete. Some changes to HLRC HLRC and related tests were required in order to deprecate ignore_throttled parameter: * Change HLRC request classes to set indices options initial value to null. This avoids sending the ignore_throttled parameter (and other indices options parameters) and therefore avoids the depracation warning header in the response. All these request classes had the indices options set to what is the defaukt in the corresponding action request class. So sending these indices options params was a noop, which is the same as not sending indices options parameters, which is what this change does. * For transport action request classes that are reused in the HLRC as request class, change the corresponding hlrc request converter to only send indices options params if the indices options are different than what the default is. * For tests that use a non default indices options, allow 'ignore_throttled is deprecated' warning. Other changes: * A number of tests have been changed to allowed warning header for deprecated ignore_throttled parameter. * Some rest v7 compat yaml tests are temporary muted, but will be unmuted once this change has been backported. Relates to #70192 * adjust to 7.x reality * adjust to 7.x reality (2) * adjust 7.x request converters * more 7.x adjustments
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Sep 18, 2021
* master: (185 commits) Implement get and containsKey in terms of the wrapped innerMap (elastic#77965) Adjust Lucene version and enable BWC tests (elastic#77933) Disable BWC to upgrade to Lucene-8.10-snapshot Reenable MlDistributedFailureIT [DOCS] Fix typo for `script.painless.regex.enabled` setting value (elastic#77853) Upgrade to Lucene-8.10.0-snapshot-bf2fcb53079 (elastic#77801) [DOCS] Fix ESS install lead-in (elastic#77887) Resolve thirdparty gradle plugin artifacts from mavencentral (elastic#77865) Reduce the number of times that `LifecycleExecutionState` is parsed when running a policy. (elastic#77863) Utility methods to add and remove backing indices from data streams (elastic#77778) Use Objects.equals() instead of == to compare strings (elastic#77840) [ML] prefer least allocated model when a new node is added to the cluster (elastic#77756) Deprecate ignore_throttled parameter (elastic#77479) Improve LifecycleExecutionState parsing. (elastic#77855) [DOCS] Removes deprecated word from HLRC title. (elastic#77851) Remove legacy geo code from AggregationResultUtils (elastic#77702) Adjust SearchableSnapshotsBlobStoreCacheIntegTests.testBlobStoreCache (elastic#77758) Laxify SecureSM to allow creation of the JDK's innocuous threads (elastic#77789) [Test] Reduce concurrency when testing creation of security index (elastic#75293) Refactor metric PipelineAggregation integration test (elastic#77548) ... # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frozen indices are deprecated, which will make ignore_throttled obsolete.
Some changes to HLRC HLRC and related tests were required in order to deprecate ignore_throttled parameter:
This avoids sending the ignore_throttled parameter (and other indices options parameters)
and therefore avoids the depracation warning header in the response. All these
request classes had the indices options set to what is the default in the corresponding
action request class. So sending these indices options params was a noop, which is the same
as not sending indices options parameters, which is what this change does.
change the corresponding hlrc request converter to only send indices options params
if the indices options are different than what the default is.
warning.
Other changes:
change has been backported.
Relates to #70192