Support for aggregation names with dots in first element path of a pipeline aggregation #77481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peline aggregation
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
iverase
commented
Sep 9, 2021
| @@ -45,6 +45,9 @@ | |||
| static int numValueBuckets; | |||
| static long[] valueCounts; | |||
|
|
|||
| static String histoName; | |||
| static String termsName; | |||
|
|
|||
There was a problem hiding this comment.
I have only do it for one test but maybe we should do it for all of them for consistency? Maybe a follow up PR?
There was a problem hiding this comment.
Yeah, I think that'd be good to do in a follow up PR.
not-napoleon
approved these changes
Sep 9, 2021
| private static String randomName() { | ||
| return randomBoolean() | ||
| ? randomAlphaOfLengthBetween(3, 12) | ||
| : randomAlphaOfLengthBetween(3, 6) + "." + randomAlphaOfLengthBetween(3, 6); |
There was a problem hiding this comment.
We should test non-ascii characters too, probably in a follow up PR. Or just open a ticket for it, could be a good first issue for someone.
| @@ -45,6 +45,9 @@ | |||
| static int numValueBuckets; | |||
| static long[] valueCounts; | |||
|
|
|||
| static String histoName; | |||
| static String termsName; | |||
|
|
|||
There was a problem hiding this comment.
Yeah, I think that'd be good to do in a follow up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the first element on the path of a pipeline aggregation refers to an aggregation with a name containing a dot, the aggregation fails as it does not save properly the aggregation name during validation. This is due that the validation it's own parsing strategy that cannot deal with such names.
This PR changes the strategy during validation is it uses
AggregationPathto resolve the name.