Enable deprecation log indexing by default #78319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgomulka
added
:Core/Infra/Logging
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
pgomulka
commented
Sep 27, 2021
.../src/main/java/org/elasticsearch/xpack/deprecation/logging/DeprecationIndexingComponent.java
Outdated
Show resolved
Hide resolved
…n_indexing_by_default
…n_indexing_by_default
…n_indexing_by_default
…n_indexing_by_default
…n_indexing_by_default
…n_indexing_by_default
pugnascotia
reviewed
Oct 6, 2021
| @@ -234,6 +234,17 @@ The user ID is included in the `X-Opaque-ID` field in deprecation JSON logs. | |||
| --------------------------- | |||
| // NOTCONSOLE | |||
|
|
|||
| Deprecation logs are indexed into `.logs-deprecation.elasticsearch-default` data stream by default. | |||
| You can disable deprecation log indexing by changing a | |||
There was a problem hiding this comment.
Suggested change
| You can disable deprecation log indexing by changing a | |
| You can disable deprecation log indexing by changing the |
pugnascotia
reviewed
Oct 6, 2021
|
|
||
| ==== Deprecation logs throttling | ||
| Deprecation logs are deduplicated based on a deprecated feature key | ||
| and x-opaque-id so that if a feature is repeatedly used, it will not overload the deprecation logs. |
There was a problem hiding this comment.
Can we link x-opaque-id to a description somewhere?
pugnascotia
reviewed
Oct 6, 2021
| @@ -782,7 +782,7 @@ protected static void wipeAllIndices() throws IOException { | |||
| boolean includeHidden = minimumNodeVersion().onOrAfter(Version.V_7_7_0); | |||
| try { | |||
| //remove all indices except ilm history which can pop up after deleting all data streams but shouldn't interfere | |||
| final Request deleteRequest = new Request("DELETE", "*,-.ds-ilm-history-*"); | |||
| final Request deleteRequest = new Request("DELETE", "*,-.ds-ilm-history-*,-.ds-.logs-deprecation.elasticsearch-default-*"); | |||
There was a problem hiding this comment.
Did you ask the Data Management team about this?
pugnascotia
reviewed
Oct 6, 2021
|
|
||
| ObjectMapper mapper = new ObjectMapper(); | ||
| final JsonNode jsonNode = mapper.readTree(response.getEntity().getContent()); | ||
| logger.warn(documents); |
There was a problem hiding this comment.
I don't think we want this linen now.
pugnascotia
reviewed
Oct 6, 2021
| @@ -121,6 +125,7 @@ | |||
| /** | |||
| * Base class of ML integration tests that use a native autodetect process | |||
| */ | |||
| //@ESIntegTestCase.ClusterScope(scope = TEST, numClientNodes = 0, maxNumDataNodes = 1) | |||
pgomulka
commented
Oct 6, 2021
| ).actionGet(); | ||
| assertAcked(response); | ||
| } | ||
|
|
||
| @Override | ||
| protected void beforeIndexDeletion() throws Exception { | ||
| super.beforeIndexDeletion(); |
There was a problem hiding this comment.
this is problematic, because if we want to remove indices on cleanup we have to remember to disable deprecation log indexing. Otherwise it might create a deprecation and recreate datastream and its indices.
|
closing in favour of #78991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation logs indexing is enabled by default. As before XOpaqueId is used for logs throttling, but it can be turned off and be ignored which can be useful for smaller clusters.
closes #76292
closes #77936