Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add transform breaking changes #79531

Merged
merged 7 commits into from
Oct 25, 2021
Merged

[DOCS] Add transform breaking changes #79531

merged 7 commits into from
Oct 25, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 20, 2021 •
edited
Loading

Relates to #77566

This PR adds breaking change documentation for the transform upgrades.
Edits to the deprecation messages were moved to #79601 .

Preview

https://elasticsearch_79531.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/migrating-8.0.html#breaking_80_transform_changes

hendrikmuhs
hendrikmuhs reviewed Oct 20, 2021
View reviewed changes
Copy link
Contributor

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it, this was on my todo list, but I am happy to pass it over.

...in/core/src/main/java/org/elasticsearch/xpack/core/transform/transforms/TransformConfig.java Outdated Show resolved Hide resolved
@hendrikmuhs
Copy link
Contributor

Regarding the migration guide:

Transforms created 7.2 - 7.4 must be upgraded.

Details

Transform configurations from early beta versions - 7.2 - 7.4 - must be upgraded using the transform upgrade endpoint.

Impact

Transforms that are still in the old format are not supported after upgrade.

@hendrikmuhs
Copy link
Contributor

@lcawl I inlined your changes into #79601, I hope that's ok for you. It fixes some more issues of the upgrader.

@lcawl lcawl changed the title Edit transform deprecation messages [DOCS] Add transform breaking changes Oct 21, 2021
@lcawl lcawl added :ml/Transform Transform >docs General docs changes labels Oct 21, 2021
@lcawl lcawl marked this pull request as ready for review October 21, 2021 20:24
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:ML Meta label for the ML team labels Oct 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@lcawl
Copy link
Contributor Author

lcawl commented Oct 21, 2021

@elasticmachine update branch

@lcawl lcawl mentioned this pull request Oct 21, 2021
Merged
hendrikmuhs
hendrikmuhs approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit c10bf9b into elastic:master Oct 25, 2021
@lcawl lcawl deleted the transform-deprecation branch October 25, 2021 15:08
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 28, 2021
@lcawl
[DOCS] Add transform breaking changes (elastic#79531)
effd8f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

Assignees
No one assigned
Labels
>docs General docs changes :ml/Transform Transform Team:Docs Meta label for docs team Team:ML Meta label for the ML team v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @hendrikmuhs @elasticmachine @jakelandis @elasticsearchmachine