Move SnapshotsRecoveryPlannerService to its own x-pack plugin #79637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcofdez
force-pushed
the
license-take-2
branch
from
ee373e2
to
a0bb0e1
Compare
|
@henningandersen I'm leaving this as a draft since I think there's a problem in the task wiring for the qa tests, but it would be nice to get this reviewed. The changes are really similar to #78928 the change-set is large since automatic formatting is applied to new projects and therefore it has changed everything :D. I copied the relevant tests from |
fcofdez
force-pushed
the
license-take-2
branch
from
a0bb0e1
to
a2e9138
Compare
|
@elasticsearchmachine test this please |
henningandersen
approved these changes
Oct 26, 2021
...ork/src/main/java/org/elasticsearch/indices/recovery/AbstractIndexRecoveryIntegTestCase.java
Show resolved
Hide resolved
| throw new IllegalStateException("A single RecoveryPlannerPlugin was expected but got: " + recoveryPlannerPlugins); | ||
| } | ||
|
|
||
| final ShardSnapshotsService shardSnapshotsService = new ShardSnapshotsService(client, |
There was a problem hiding this comment.
Maybe we could also move the creation of this service and the service into the x-pack module as a follow-up? No need to do it now.
x-pack/plugin/snapshot-based-recoveries/qa/license-enforcing/build.gradle
Show resolved
Hide resolved
fcofdez
added
the
:Distributed/Recovery
This was referenced Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.