Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Security ON by default beta updates #79641

Merged

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Oct 21, 2021

Documentation updates for 8.0 Beta changes related to security ON by default.

Preview link: https://elasticsearch_79641.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/configuring-stack-security.html

@lockewritesdocs
Copy link
Contributor Author

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

merge conflict between base and head

@lockewritesdocs lockewritesdocs added :Security/TLS SSL/TLS, Certificates >docs General docs changes v8.0.0-beta1 v8.1.0 labels Oct 27, 2021
@lockewritesdocs lockewritesdocs marked this pull request as ready for review November 1, 2021 12:19
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Security Meta label for security team labels Nov 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@jkakavas jkakavas self-requested a review November 1, 2021 19:08
@@ -1,55 +1,22 @@
[[configuring-stack-security]]
== Start the Elastic Stack with security enabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Think we had this discussion in a previous PR too. I find the extensive introduction which repeats a large part of the information that we include below in [[stack-start-with-security]] too, a bit confusing, Maybe it's just me thought, if we think this is helpful for users, +1 to leave as is. Just wanted to raise this and we can iterate for GA if need be

@jkakavas
Copy link
Member

jkakavas commented Nov 2, 2021

Added some more minor comments in case they're helpful. After we resolve #79641 (comment), I think we're god to merge but I'm happy to take another look during the day

Adam Locke and others added 2 commits November 2, 2021 08:25
Co-authored-by: Ioannis Kakavas <ikakavas@protonmail.com>
. From the installation directory of your other node, start {es} and pass the
enrollment token with the `--enrollment token` parameter. This is the enrollment
token that was generated when you started your first {es} node.
. In a separate terminal from where {es} is running, navigate to the directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lockewritesdocs lockewritesdocs added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Nov 2, 2021
@lockewritesdocs lockewritesdocs merged commit 6db2f96 into elastic:master Nov 2, 2021
@lockewritesdocs lockewritesdocs deleted the docs__security-on-beta branch November 2, 2021 18:42
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Nov 2, 2021
* [DOCS] Security ON by default beta updates

* Remove interactive flag for Kibana

* Change to Kibana /data directory

* Update introduction and password reset tool reference

* Incorporating review feedback

* Remove enroll-node from command

* Apply suggestions from code review

Co-authored-by: Ioannis Kakavas <ikakavas@protonmail.com>

* Clarify enrollment node steps

Co-authored-by: Ioannis Kakavas <ikakavas@protonmail.com>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0

elasticsearchmachine pushed a commit that referenced this pull request Nov 2, 2021
* [DOCS] Security ON by default beta updates

* Remove interactive flag for Kibana

* Change to Kibana /data directory

* Update introduction and password reset tool reference

* Incorporating review feedback

* Remove enroll-node from command

* Apply suggestions from code review

Co-authored-by: Ioannis Kakavas <ikakavas@protonmail.com>

* Clarify enrollment node steps

Co-authored-by: Ioannis Kakavas <ikakavas@protonmail.com>

Co-authored-by: Ioannis Kakavas <ikakavas@protonmail.com>
@jakelandis jakelandis removed the v8.0.0 label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >docs General docs changes :Security/TLS SSL/TLS, Certificates Team:Docs Meta label for docs team Team:Security Meta label for security team v8.0.0-beta1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants