Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REST API compatibility] Move _xpack prefix compat tests followup #79859

Merged
merged 3 commits into from
Oct 26, 2021

Conversation

joegallo
Copy link
Contributor

Fixup PR for #79501 -- changing the path here from [...]/rest-api-spec.test.monitoring.bulk to [...]/rest-api-spec/test/monitoring.bulk. My read of things is that without this change this particular monitoring.bulk test stuff never actually got executed.

@joegallo joegallo added >non-issue :Delivery/Build Build or test infrastructure v8.0.0 labels Oct 26, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Oct 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@joegallo
Copy link
Contributor Author

 ./gradlew ':x-pack:qa:xpack-prefix-rest-compat:yamlRestTestV7CompatTest' --tests "org.elasticsearch.xpack.test.rest.XPackRestIT" -Dtests.method="test {p0=monitoring.bulk/10_basic_compat/*}"

Exercises just the one test I moved here -- prior to this PR I'm not sure there's a line you could type that would execute it.

Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joegallo joegallo merged commit afc2374 into elastic:master Oct 26, 2021
@joegallo joegallo deleted the move_xpack_prefix_testing-followup branch October 26, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants