Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REST API compatibility] special handling for _freeze #79861

Merged
merged 11 commits into from
Oct 26, 2021
Merged

[REST API compatibility] special handling for _freeze #79861

merged 11 commits into from
Oct 26, 2021

Commits on Oct 26, 2021

  1. Add back _freeze under rest api compatibility 

    We just always respond with a 400 bad request (even if you ask to
freeze an index that doesn't actually exist).
    @joegallo
    joegallo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    3fcd40f View commit details
    Browse the repository at this point in the history

  2. Better error response codes 

    404 on an index that doesn't exist, 410 on one that does exist.
    @joegallo
    joegallo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    031aa70 View commit details
    Browse the repository at this point in the history

  3. Squash merge branch 'move_xpack_prefix_testing-followup' into freeze-… 

    …rest-compatibility
    @joegallo
    joegallo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    8ad3d61 View commit details
    Browse the repository at this point in the history

  4. Add some rest tests

    @joegallo
    joegallo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    882b022 View commit details
    Browse the repository at this point in the history

  5. Fix formatting

    @joegallo
    joegallo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a7d3cf6 View commit details
    Browse the repository at this point in the history

  6. Need to skip this 7.16 test now 

    On 7.16 it fails with a 400 bad request because we don't allow this
operation (semantically), on master it was failing with a 400 bad
request because we removed the freeze endpoint entirely, so it
happened to pass. Now that I have _freeze requests responding with 410
gone, this test is now failing, so we have to skip it.

This surprised me a little at first, but I really do think this is all
correct.
    @joegallo
    joegallo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    d436529 View commit details
    Browse the repository at this point in the history

  7. We don't need to define freeze_gone, actually

    @joegallo
    joegallo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    c5c18e7 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into freeze-rest-compatibility

    @joegallo
    joegallo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    61cfa34 View commit details
    Browse the repository at this point in the history

  9. Moved the new freeze.gone test to x-pack/plugin

    @joegallo
    joegallo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    bf5c7a5 View commit details
    Browse the repository at this point in the history

  10. Don't need to skip this, it can be rewritten

    @joegallo
    joegallo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    29c3230 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into freeze-rest-compatibility

    @joegallo
    joegallo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    441a82d View commit details
    Browse the repository at this point in the history