Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update ES quick start for security ON by default #80735

Merged

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Nov 15, 2021

Updates the Elasticsearch quickstart guide to reflect behavior with security ON by default.

Preview link: https://elasticsearch_80735.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/getting-started.html

Click the Self-managed tab to view changes.

@lockewritesdocs lockewritesdocs added >docs General docs changes :Security/Security Security issues without another label v8.0.0 auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.1.0 labels Nov 15, 2021
@lockewritesdocs lockewritesdocs self-assigned this Nov 15, 2021
@elasticmachine elasticmachine added Team:Security Meta label for security team Team:Docs Meta label for docs team labels Nov 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@lockewritesdocs
Copy link
Contributor Author

@elasticmachine update branch

@lockewritesdocs
Copy link
Contributor Author

@elasticmachine run docs

@@ -21,9 +21,37 @@ Desktop].
----
docker network create elastic
docker pull {docker-repo}:{version}
docker run --name es01-test --net elastic -p 9200:9200 -p 9300:9300 -e "discovery.type=single-node" {docker-image}
docker run --name es-node01 -p 9200:9200 -p 9300:9300 -it {docker-image}
Copy link
Member

@jkakavas jkakavas Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's leave the --net elastic (both here and for kibana) , I think it's good practice to have a specific docker network

Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge when the comment is addressed

@lockewritesdocs lockewritesdocs merged commit 247d124 into elastic:master Nov 17, 2021
@lockewritesdocs lockewritesdocs deleted the docs__update-getting-started branch November 17, 2021 22:48
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Nov 17, 2021
* [DOCS] Update ES quick start for security ON by default

* Remove code.asciidoc, which is part of the overall doc build now

* Update node names for cleanup

* Add note with links to tools

* Add --net elastic network

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0

elasticsearchmachine pushed a commit that referenced this pull request Nov 17, 2021
)

* [DOCS] Update ES quick start for security ON by default

* Remove code.asciidoc, which is part of the overall doc build now

* Update node names for cleanup

* Add note with links to tools

* Add --net elastic network

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >docs General docs changes :Security/Security Security issues without another label Team:Docs Meta label for docs team Team:Security Meta label for security team v8.0.0-rc1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants