Fix references to moved classes in plugin examples #80736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 15, 2021
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fixes to our example plugins. First, we should always add log4j to the test runtime classpath so plugin authors don't have to do this, second, we moved some x-content classes as part of our modularlization work so plugins and test that use these need to be updated as well.