Enable data stream lifecycle feature flag in x-pack plugin tests (98050) #98133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>test
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
andreidan
approved these changes
Aug 2, 2023
x-pack/plugin/build.gradle
Outdated
| @@ -227,6 +227,9 @@ testClusters.configureEach { | |||
|
|
|||
| requiresFeature 'es.index_mode_feature_flag_registered', Version.fromString("8.0.0") | |||
| requiresFeature 'es.inference_rescorer_feature_flag_enabled', Version.fromString("8.10.0") | |||
| if (BuildParams.isSnapshotBuild() == false) { | |||
There was a problem hiding this comment.
Is this if statement redundant? (the flag is always enabled in snapshot builds)
There was a problem hiding this comment.
That is true, but this is how we do it in the other tests, that's why I did this here too. I am happy to clean it here and keep it inline with the other feature flags. Any objections to remove the conditional?
gmarouli
added
auto-merge
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Aug 3, 2023
…50) (elastic#98133) Added missing feature flag. The reason this used work was that we would not take into account the value of the feature flag in the usage response. This changed in elastic#97442 & elastic#97425. Fixes: elastic#98050 (cherry picked from commit 42840e0) # Conflicts: # x-pack/plugin/build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing feature flag. The reason this used work was that we would not take into account the value of the feature flag in the usage response. This changed in #97442 & #97425.
Fixes: #98050