-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable data stream lifecycle feature flag in x-pack plugin tests (98050) #98133
Conversation
Pinging @elastic/es-data-management (Team:Data Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this Mary
x-pack/plugin/build.gradle
Outdated
@@ -227,6 +227,9 @@ testClusters.configureEach { | |||
|
|||
requiresFeature 'es.index_mode_feature_flag_registered', Version.fromString("8.0.0") | |||
requiresFeature 'es.inference_rescorer_feature_flag_enabled', Version.fromString("8.10.0") | |||
if (BuildParams.isSnapshotBuild() == false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this if statement redundant? (the flag is always enabled in snapshot builds)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is true, but this is how we do it in the other tests, that's why I did this here too. I am happy to clean it here and keep it inline with the other feature flags. Any objections to remove the conditional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…50) (elastic#98133) Added missing feature flag. The reason this used work was that we would not take into account the value of the feature flag in the usage response. This changed in elastic#97442 & elastic#97425. Fixes: elastic#98050 (cherry picked from commit 42840e0) # Conflicts: # x-pack/plugin/build.gradle
Added missing feature flag. The reason this used work was that we would not take into account the value of the feature flag in the usage response. This changed in #97442 & #97425.
Fixes: #98050