Allow aggs to disable offloading sequential collection #98276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#98204 we are introducing unconditional offloading of collection to a separate thread pool, even for requests of phases that don't enable search concurrency. It turns out that some aggs don't support offloading their collection to a separate thread, as their postCollect method is executed on the search thread which trips a lucene assertion around reusing data structures pulled from the search worker thread. With this commit we allow aggs to specify when they don't support offloading their sequential collection. Such aggs are a subset of the ones that already declare that they don't support concurrency entirely. Relates to elastic#96023
javanna
added
:Analytics/Aggregations
elasticsearchmachine
added
Team:Search
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Pinging @elastic/es-search (Team:Search) |
martijnvg
approved these changes
Aug 8, 2023
test/framework/src/main/java/org/elasticsearch/search/aggregations/BaseAggregationTestCase.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #98204 we are introducing unconditional offloading of collection to a separate thread pool, even for requests of phases that don't enable search concurrency. It turns out that some aggs don't support offloading their collection to a separate thread, as their postCollect method is executed on the search thread which trips a lucene assertion around reusing data structures pulled from the search worker thread.
With this commit we allow aggs to specify when they don't support offloading their sequential collection. Such aggs are a subset of the ones that already declare that they don't support concurrency entirely.
Relates to #96023