Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Document IP filtering for RCS 2.0 #98553

Merged
merged 7 commits into from
Aug 25, 2023
Merged

[Docs] Document IP filtering for RCS 2.0 #98553

merged 7 commits into from
Aug 25, 2023

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Aug 17, 2023

This PR adds documentation for RCS 2.0 IP filtering.

Relates: #98472

@ywangd
[Docs] Document IP filtering for RCS 2.0
bd0065b 
This PR adds documentation for RCS 2.0 IP filtering.
@ywangd ywangd added >docs General docs changes :Security/Security Security issues without another label v8.10.0 v8.11.0 labels Aug 17, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Security Meta label for security team labels Aug 17, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

ywangd
ywangd commented Aug 17, 2023
View reviewed changes
docs/reference/settings/security-settings.asciidoc
==== IP filtering settings
=== IP filtering settings
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the existing indentation level is incorrect for the right sidebar. This section should be at the same level as TLS settings.

ywangd
ywangd commented Aug 17, 2023
View reviewed changes
docs/reference/settings/security-hash-settings.asciidoc
==== User cache and password hash algorithms
=== User cache and password hash algorithms
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as well.

ywangd
ywangd commented Aug 17, 2023
View reviewed changes
x-pack/docs/en/security/using-ip-filtering.asciidoc
Comment on lines -115 to +139
==== Dynamically updating IP filter settings
=== Dynamically updating IP filter settings
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here as well.

n1v0lg
n1v0lg approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Build failures all look related to version bump fallout from a few days.

@ywangd
Copy link
Member Author

ywangd commented Aug 22, 2023

@elasticmachine update branch

@ywangd
Copy link
Member Author

ywangd commented Aug 24, 2023

@elasticmachine update branch

@ywangd
Copy link
Member Author

ywangd commented Aug 24, 2023

@abdonpijpelink Could you please take a look at this PR when convenient? Thanks!

abdonpijpelink
abdonpijpelink approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've left two suggestions.

x-pack/docs/en/security/using-ip-filtering.asciidoc Outdated Show resolved Hide resolved
x-pack/docs/en/security/using-ip-filtering.asciidoc Outdated Show resolved Hide resolved
@ywangd @abdonpijpelink
Apply suggestions from code review
94e5dbd 
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
@ywangd
Copy link
Member Author

ywangd commented Aug 25, 2023

@elasticmachine update branch

@ywangd ywangd added auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Aug 25, 2023
@elasticsearchmachine elasticsearchmachine merged commit f307e6f into elastic:main Aug 25, 2023
15 checks passed
@ywangd ywangd deleted the rcs2-doc-ip-filtering branch August 25, 2023 03:24
@ywangd ywangd mentioned this pull request Aug 25, 2023
Merged
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Aug 25, 2023
@ywangd
[Docs] Document IP filtering for RCS 2.0 (elastic#98553)
914c03f 
This PR adds documentation for RCS 2.0 IP filtering.

Relates: elastic#98472
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.10

elasticsearchmachine pushed a commit that referenced this pull request Aug 25, 2023
@ywangd
[Docs] Document IP filtering for RCS 2.0 (#98553) (#98860)
dde3908 
This PR adds documentation for RCS 2.0 IP filtering.

Relates: #98472
bpintea pushed a commit to bpintea/elasticsearch that referenced this pull request Aug 25, 2023
@ywangd @bpintea
[Docs] Document IP filtering for RCS 2.0 (elastic#98553)
ab3abec 
This PR adds documentation for RCS 2.0 IP filtering.

Relates: elastic#98472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdonpijpelink abdonpijpelink abdonpijpelink approved these changes

@n1v0lg n1v0lg n1v0lg approved these changes

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >docs General docs changes :Security/Security Security issues without another label Team:Docs Meta label for docs team Team:Security Meta label for security team v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ywangd @elasticsearchmachine @abdonpijpelink @n1v0lg @elasticmachine