Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downsample failure when FLS/DLS is enabled. #98587

Merged

Commits on Aug 17, 2023

  1. Fix downsample failure when FLS/DLS is enabled.

    If FLS/DLS is enabled (this is the case when trial/licence is active and security is enabled) then invoking the downsample API results in immediate failure.
    
    The downsample shard persistent task executor opens a searcher, but security didn't set indices permissions in the thread local (this happens via SecurityActionFilter). This will only happen on indices actions (which are actions with a request that implement IndicesRequest. This change does this by delegating to a transport action that executes always locally, and this way security prepares thread local headers correctly.
    
    This adds another layer of indirection, but without doing this FLS/DLS wouldn't work.
    
    Closes elastic#98569
    martijnvg committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ec5cc8d View commit details
    Browse the repository at this point in the history
  2. spotless

    martijnvg committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    65fa59b View commit details
    Browse the repository at this point in the history
  3. s/rollup/downsample/

    martijnvg committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    84558dc View commit details
    Browse the repository at this point in the history
  4. updated test

    martijnvg committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    4563612 View commit details
    Browse the repository at this point in the history