Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10] Set default index mode for TimeSeries to null (#98586) #98780

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

kkrik-es
Copy link
Contributor

Backports the following commits to 8.10:

* Default index mode null for TimeSeries

If the default index mode matches the specified, we skip printing the
synthetic source info in the mappings printing. This leads to confusion
as it's not immediately visible (or well known) that time series indices
use synthetic source by default.

Leaving the default index mode to null does the trick here. We do pass
the right value for time series indexes while building the mapping so
there's no functional impact here.

Fixes elastic#97429

* Update docs/changelog/98586.yaml

* Restore other error messages.

* Update source in DocumentMapper to include synthetic source.

* Add version check for skipping assert
@kkrik-es kkrik-es added :Analytics/Aggregations Aggregations >bug backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Aug 23, 2023
@kkrik-es kkrik-es self-assigned this Aug 23, 2023
@kkrik-es kkrik-es added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 23, 2023
@elasticsearchmachine elasticsearchmachine merged commit 8e0f6a6 into elastic:8.10 Aug 23, 2023
12 checks passed
@kkrik-es kkrik-es deleted the backport/8.10/pr-98586 branch August 23, 2023 10:17
@JVerwolf JVerwolf added v8.10.0 and removed v8.10.1 labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants