Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10] Rollback of #98586 (#98805) #98806

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

kkrik-es
Copy link
Contributor

Backports the following commits to 8.10:

* Skip segment for MatchNoDocsQuery filters.

When a query of a filter gets rewritten to MatchNoDocsQuery, segments
will not produce any results. We can therefore skip processing such
segments.

This applies to FilterByFilterAggregator and FiltersAggregator, as well
as to TermsAggregator when it uses StringTermsAggregatorFromFilters
internally; the latter is an adapter aggregator to
FilterByFilterAggregator.

Fixes elastic#94637

* Update docs/changelog/98295.yaml

* Check all filters for `MatchNoDocsQuery`.

* Skip optimization when 'other' bucket is requested.

* Revert "Set default index mode for TimeSeries to `null` (elastic#98586)"

This reverts commit 56abb86.
@kkrik-es kkrik-es added :Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Aug 23, 2023
@kkrik-es kkrik-es self-assigned this Aug 23, 2023
@elasticsearchmachine elasticsearchmachine merged commit a60ab5c into elastic:8.10 Aug 23, 2023
12 checks passed
@kkrik-es kkrik-es deleted the backport/8.10/pr-98805 branch August 23, 2023 15:47
@JVerwolf JVerwolf added v8.10.0 and removed v8.10.1 labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants