Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] fix BWC error when upgrading from 7.x #99948

Merged

Conversation

hendrikmuhs
Copy link
Contributor

@hendrikmuhs hendrikmuhs commented Sep 27, 2023

fix a regression introduced in #99914: the timeout variable can be null if upgraded from 7

relates #99914
fixes #99945

Note: This fix is already part of the backport of the original PR #99940, no backport needed for this PR.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Sep 27, 2023
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs
Copy link
Contributor Author

There is currently a problem with doc builds affecting all PR's. It is actively worked on. This PR has no doc changes at all, but it fixes an issue that might create a lot of noise until fixed. I will therefore merge this now.

@hendrikmuhs hendrikmuhs merged commit 9ea5250 into elastic:main Sep 27, 2023
10 of 11 checks passed
piergm pushed a commit to piergm/elasticsearch that referenced this pull request Oct 2, 2023
fix a regression introduced in elastic#99914: the timeout variable can be null if upgraded from 7

relates elastic#99914
fixes elastic#99945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml/Transform Transform >non-issue Team:ML Meta label for the ML team v8.11.0
Projects
None yet
3 participants