Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECURITY-ENDPOINT: reconcile host.name and host.hostname #20

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

nnamdifrankie
Copy link
Contributor

Issue:

elastic/kibana#70201

  • add host.name to metadata document.
  • add host.name and host.hostname to policy document.

@kevinlog
Copy link
Contributor

@nnamdifrankie good call on adding in the rest of what's available - are there a lot of implications to tests when the schema adds a lot more fields?

@jonathan-buttner
Copy link
Collaborator

@nnamdifrankie good call on adding in the rest of what's available - are there a lot of implications to tests when the schema adds a lot more fields?

Naa, I don't think so. The only change here would be that the fields are searchable but the backend isn't going to leverage that right now. I guess we could test that that the documents are still displayed correctly in the UI but that shouldn't have changed because the backend would be returning the entire document previously anyway.

@nnamdifrankie
Copy link
Contributor Author

@kevinlog I have to update the typescript types, but I think the data is pliable and where it is missing will be undefined as per the tests.

@nnamdifrankie nnamdifrankie merged commit 4a27d69 into master Jun 29, 2020
@nnamdifrankie nnamdifrankie deleted the ENDPOINT_add_name_to_host branch June 29, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants