Skip to content

Commit

Permalink
[EuiIcon] Fix missing style prop on custom icons (#6888)
Browse files Browse the repository at this point in the history
* [EuiIcon] Fix missing `style` prop on custom icons

+ add `shouldRenderCustomStyles` test to ensure this doesn't regress

* changelog
  • Loading branch information
cee-chen authored Jun 29, 2023
1 parent 1f8e4db commit 17e0d61
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/components/icon/icon.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ function testIcon(props: PropsOf<typeof EuiIcon>) {
describe('EuiIcon', () => {
test('is rendered', testIcon({ type: 'search', ...requiredProps }));

shouldRenderCustomStyles(<EuiIcon type="customImg" />);
shouldRenderCustomStyles(<EuiIcon type="videoPlayer" />);

describe('props', () => {
Expand Down
1 change: 1 addition & 0 deletions src/components/icon/icon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ export class EuiIconClass extends PureComponent<
src={icon}
className={classes}
css={cssStyles}
style={style}
tabIndex={tabIndex}
{...(rest as ImgHTMLAttributes<HTMLImageElement>)}
/>
Expand Down
4 changes: 4 additions & 0 deletions upcoming_changelogs/6888.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
**Bug fixes**

- Fixed `EuiIcon` not correctly passing the `style` prop custom `img` icons

0 comments on commit 17e0d61

Please sign in to comment.