Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed position of EuiCodeBlock controls #2459

Merged
merged 13 commits into from
Oct 25, 2019
Merged

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Oct 21, 2019

I keep noticing that the controls would stay in one location no matter how you changed the paddingSize of the EuiCodeBlock.

Before example:

Screen Shot 2019-10-21 at 17 07 51 PM

This PR, adjusts that position based on the padding size.

After example:

Screen Shot 2019-10-21 at 17 27 03 PM

Note: The docs change is just temporary to quickly showcase the different examples. I'll revert before merging.

Also,

I beefed up the tests. At the time there was only a single "it renders" test. This adds more for each prop.

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@cchaos cchaos merged commit 54436b2 into elastic:master Oct 25, 2019
@cchaos cchaos deleted the code-block-extras branch October 25, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants