Fix overflowHeight in EuiCodeBlock #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
reviewed
Oct 24, 2019
src/components/code/_code_block.js
Outdated
| @@ -255,7 +257,9 @@ export class EuiCodeBlockImpl extends Component { | |||
|
|
|||
| return ( | |||
| <div {...wrapperProps}> | |||
| <pre className="euiCodeBlock__pre">{codeSnippet}</pre> | |||
| <pre style={preOptionalStyles} className="euiCodeBlock__pre"> | |||
There was a problem hiding this comment.
I don't see a difference between optionalStyles and preOptionalStyles. Likely you can just use optionalStyles here and not need to declare an extra const.
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| **Bug fixes** | |||
|
|
|||
| - Normalized button `moz-focus-inner` ([#2445](https://github.com/elastic/eui/pull/2445)) | |||
| - Fixed `overflowHeight` in `EuiCodeBlock` ([#2487](https://github.com/elastic/eui/pull/2487)) | |||
There was a problem hiding this comment.
Suggested change
| - Fixed `overflowHeight` in `EuiCodeBlock` ([#2487](https://github.com/elastic/eui/pull/2487)) | |
| - Changed `EuiCodeBlock` so that `overflowHeight` now applies a `maxHeight` instead of a `height` on the block ([#2487](https://github.com/elastic/eui/pull/2487)) |
It's OK to be verbose in change logs. People go to them primarily when things break. Did something change? What was the change?
snide
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing issue where
EuiCodeBlockalways expands to givenoverflowHeighteven when content does not require it. Fixes #2435Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes