Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert remaining range components to TS #2732

Merged
merged 7 commits into from
Jan 7, 2020
Merged

Convert remaining range components to TS #2732

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
57dcb57
convert remaining range components to TS
thompsongl Jan 3, 2020
bab75a0
Merge branch 'master' into range-convert
thompsongl Jan 3, 2020
455370b
default props
thompsongl Jan 6, 2020
1ee66ba
Merge branch 'master' into range-convert
thompsongl Jan 6, 2020
7c32cd7
update
thompsongl Jan 6, 2020
68f709a
more exports
thompsongl Jan 6, 2020
167d623
EuiRangeSliderProps
thompsongl Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/form/form_control_layout/form_control_layout_delimited.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,12 @@ import React, {
import classNames from 'classnames';

import { EuiText } from '../../text';
import { EuiFormControlLayout } from './form_control_layout';
import {
EuiFormControlLayout,
EuiFormControlLayoutProps,
} from './form_control_layout';

type EuiFormControlLayoutDelimitedProps = Partial<EuiFormControlLayout> & {
type EuiFormControlLayoutDelimitedProps = Partial<EuiFormControlLayoutProps> & {
/**
* Left side control
*/
Expand Down
1 change: 0 additions & 1 deletion src/components/form/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { CommonProps } from '../common';
/// <reference path="./field_search/index.d.ts" />
/// <reference path="./form_row/index.d.ts" />
/// <reference path="./range/index.d.ts" />
/// <reference path="./select/index.d.ts" />
/// <reference path="./super_select/index.d.ts" />

Expand Down
38 changes: 19 additions & 19 deletions ...nge/__snapshots__/dual_range.test.js.snap → ...ge/__snapshots__/dual_range.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ exports[`EuiDualRange is rendered 1`] = `
>
<div
class="euiRangeHighlight__progress"
style="margin-left:0%;width:77.77777777777779%"
style="margin-left:1%;width:7.000000000000001%"
/>
</div>
<input
Expand All @@ -86,8 +86,8 @@ exports[`EuiDualRange is rendered 1`] = `
class="euiRangeSlider euiRangeSlider--hasRange euiDualRange__slider"
data-test-subj="test subject string"
id="id"
max="10"
min="1"
max="100"
min="0"
name="name"
step="1"
tabindex="-1"
Expand Down Expand Up @@ -115,7 +115,7 @@ exports[`EuiDualRange props compressed should render 1`] = `
>
<div
class="euiRangeHighlight__progress"
style="margin-left:0%;width:100%"
style="margin-left:1%;width:7.000000000000001%"
/>
</div>
<input
Expand Down Expand Up @@ -175,7 +175,7 @@ exports[`EuiDualRange props custom ticks should render 1`] = `
>
<div
class="euiRangeHighlight__progress"
style="margin-left:0%;width:100%"
style="margin-left:20%;width:80%"
/>
</div>
<input
Expand Down Expand Up @@ -210,7 +210,7 @@ exports[`EuiDualRange props disabled should render 1`] = `
>
<div
class="euiRangeHighlight__progress"
style="margin-left:0%;width:100%"
style="margin-left:1%;width:7.000000000000001%"
/>
</div>
<input
Expand Down Expand Up @@ -246,7 +246,7 @@ exports[`EuiDualRange props fullWidth should render 1`] = `
>
<div
class="euiRangeHighlight__progress"
style="margin-left:0%;width:100%"
style="margin-left:1%;width:7.000000000000001%"
/>
</div>
<input
Expand Down Expand Up @@ -280,10 +280,10 @@ exports[`EuiDualRange props inputs should render 1`] = `
aria-label="aria-label"
class="euiFieldNumber euiRangeInput euiRangeInput--min"
max="8"
min="1"
min="0"
name="name-minValue"
step="1"
style="width:3.6em"
style="width:4.4em"
type="number"
value="1"
/>
Expand All @@ -300,7 +300,7 @@ exports[`EuiDualRange props inputs should render 1`] = `
>
<div
class="euiRangeHighlight__progress"
style="margin-left:0%;width:77.77777777777779%"
style="margin-left:1%;width:7.000000000000001%"
/>
</div>
<input
Expand All @@ -309,8 +309,8 @@ exports[`EuiDualRange props inputs should render 1`] = `
class="euiRangeSlider euiRangeSlider--hasRange euiDualRange__slider"
data-test-subj="test subject string"
id="id"
max="10"
min="1"
max="100"
min="0"
name="name"
step="1"
tabindex="-1"
Expand All @@ -329,11 +329,11 @@ exports[`EuiDualRange props inputs should render 1`] = `
<input
aria-label="aria-label"
class="euiFieldNumber euiRangeInput euiRangeInput--max"
max="10"
max="100"
min="1"
name="name-maxValue"
step="1"
style="width:3.6em"
style="width:4.4em"
type="number"
value="8"
/>
Expand Down Expand Up @@ -362,7 +362,7 @@ exports[`EuiDualRange props labels should render 1`] = `
>
<div
class="euiRangeHighlight__progress"
style="margin-left:0%;width:100%"
style="margin-left:1%;width:7.000000000000001%"
/>
</div>
<input
Expand Down Expand Up @@ -414,7 +414,7 @@ exports[`EuiDualRange props levels should render 1`] = `
>
<div
class="euiRangeHighlight__progress"
style="margin-left:0%;width:100%"
style="margin-left:1%;width:7.000000000000001%"
/>
</div>
<input
Expand Down Expand Up @@ -487,7 +487,7 @@ exports[`EuiDualRange props slider should display in popover 1`] = `
aria-label="aria-label"
class="euiFieldNumber euiFormControlLayoutDelimited__input"
max="8"
min="1"
min="0"
name="name-minValue"
step="1"
type="number"
Expand All @@ -505,7 +505,7 @@ exports[`EuiDualRange props slider should display in popover 1`] = `
<input
aria-label="aria-label"
class="euiFieldNumber euiFormControlLayoutDelimited__input"
max="10"
max="100"
min="1"
name="name-maxValue"
step="1"
Expand Down Expand Up @@ -594,7 +594,7 @@ exports[`EuiDualRange props ticks should render 1`] = `
>
<div
class="euiRangeHighlight__progress"
style="margin-left:0%;width:100%"
style="margin-left:1%;width:7.000000000000001%"
/>
</div>
<input
Expand Down
25 changes: 16 additions & 9 deletions ...rm/range/__snapshots__/range.test.js.snap → ...m/range/__snapshots__/range.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ exports[`EuiRange is rendered 1`] = `
class="euiRangeSlider"
data-test-subj="test subject string"
id="id"
max="10"
min="1"
max="100"
min="0"
name="name"
step="1"
type="range"
Expand All @@ -96,6 +96,7 @@ exports[`EuiRange props compressed should render 1`] = `
min="0"
step="1"
type="range"
value="8"
/>
</div>
<div
Expand Down Expand Up @@ -143,6 +144,7 @@ exports[`EuiRange props custom ticks should render 1`] = `
min="0"
step="1"
type="range"
value="8"
/>
</div>
<div
Expand All @@ -166,6 +168,7 @@ exports[`EuiRange props disabled should render 1`] = `
min="0"
step="1"
type="range"
value="8"
/>
</div>
<div
Expand All @@ -188,6 +191,7 @@ exports[`EuiRange props fullWidth should render 1`] = `
min="0"
step="1"
type="range"
value="8"
/>
</div>
<div
Expand All @@ -207,8 +211,8 @@ exports[`EuiRange props input should render 1`] = `
aria-label="aria-label"
class="euiRangeSlider"
data-test-subj="test subject string"
max="10"
min="1"
max="100"
min="0"
name="name"
step="1"
tabindex="-1"
Expand All @@ -230,11 +234,11 @@ exports[`EuiRange props input should render 1`] = `
class="euiFieldNumber euiRangeInput euiRangeInput--max"
data-test-subj="test subject string"
id="id"
max="10"
min="1"
max="100"
min="0"
name="name"
step="1"
style="width:3.6em"
style="width:4.4em"
type="number"
value="8"
/>
Expand Down Expand Up @@ -262,6 +266,7 @@ exports[`EuiRange props labels should render 1`] = `
min="0"
step="1"
type="range"
value="8"
/>
</div>
<label
Expand Down Expand Up @@ -301,6 +306,7 @@ exports[`EuiRange props levels should render 1`] = `
min="0"
step="1"
type="range"
value="20"
/>
</div>
<div
Expand Down Expand Up @@ -359,8 +365,8 @@ exports[`EuiRange props slider should display in popover 1`] = `
class="euiFieldNumber euiRangeInput euiRangeInput--max"
data-test-subj="test subject string"
id="id"
max="10"
min="1"
max="100"
min="0"
name="name"
step="1"
type="number"
Expand Down Expand Up @@ -447,6 +453,7 @@ exports[`EuiRange props ticks should render 1`] = `
min="0"
step="1"
type="range"
value="8"
/>
</div>
<div
Expand Down
Loading