Fixing Amsterdam base line-heights #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
commented
Nov 5, 2020
| @@ -1,7 +1,23 @@ | |||
| // Import base theme first, then override | |||
| @import '../../../../global_styling/mixins/index'; | |||
There was a problem hiding this comment.
I don't think the mixin updates were trickling down to the components when using importing the index file. So this new structure ensures that it does.
| @@ -44,7 +44,8 @@ $euiFontSizeXL: $euiFontSize * nth($euiTextScale, 2) !default; // 28px | |||
| $euiFontSizeXXL: $euiFontSize * nth($euiTextScale, 1) !default; // 36px | |||
|
|
|||
| // Line height | |||
| $euiLineHeight: 1.5; | |||
| $euiLineHeight: 1.5 !default; | |||
There was a problem hiding this comment.
This one may still cause some issue within components, but we'll have to evaluate on a component by component basis.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4229/ |
miukimiu
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having calculated line-heights that don't align with our
8pxbaseline grid, was causing lots of issues inside components. The effects of these changes, however, shouldn't affect EuiText only components using theeuiFontSize[size]()mixins. It also shouldn't affect the current theme at all.This whimsical is how I evaluated the current line-heights and where we actually want to be with alignment to the baseline grid.
Some before/afters:
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes