Export some datagrid hooks #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taGridStyleSelector from EUI
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4271/ |
thompsongl
approved these changes
Nov 16, 2020
This was referenced Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exports the
useDataGridColumnSelector,useDataGridColumnSorting, anduseDataGridStyleSelectorhooks from datagrid. This was asked for by @XavierM to help unify the UX in the security timeline, as the full EuiDataGrid does not support their row renderer need.There was not a great way to export these on the EuiDataGrid object, mostly because of TypeScript, so I renamed the hooks for clarity.
I did not write documentation. I'm unsure how we want to document hooks and will bring this up with the team in our weekly discussion.
/cc @kertal this might be interesting for Discover's re-implementation of some of the popover experiences.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes