Updating Amsterdam colors to match brand #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 13, 2020 16:00
# Conflicts: # src/global_styling/variables/_colors.scss # src/themes/eui-amsterdam/eui_amsterdam_colors_dark.scss # src/themes/eui-amsterdam/eui_amsterdam_colors_light.scss # src/themes/eui-amsterdam/global_styling/variables/_buttons.scss # src/themes/eui/eui_colors_dark.scss
JessSmithSup
approved these changes
Nov 18, 2020
|
Also on a fun note, this primary palette is color blind safe ✅ as a sequential palette.
Including the dark-mode colors
|
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4284/ |
miukimiu
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly just the primary, accent, and warning colors were adjusted to align with the brand assets.
None of these changes are very drastic but having matching hex values will present a more seamless transition from web to product.
I also adjusted the dark colors a slight bit. To align a little better with the values of the brand colors but still are lighter and paler for easier use on the dark background.
Before
After
Disabled buttons
I also made a design decision to make all disabled buttons use the same default (non-fill) style. The original filled but disabled buttons did not look as much like disabled buttons as they did as just gray filled buttons. By making all disabled buttons look the same it will be much easier for users to consistently recognize when a button is disabled.
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately