Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data grid: Take scrollbar into account #4468

Merged
merged 8 commits into from
Feb 10, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions src/components/datagrid/data_grid.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,30 @@ export const EuiDataGrid: FunctionComponent<EuiDataGridProps> = (props) => {
}
}, [resizeRef, gridDimensions]);

const [virtualizeContainerWidth, setVirtualizeContainerWidth] = useState(0);
chandlerprall marked this conversation as resolved.
Show resolved Hide resolved
const virtualizeContainer = resizeRef?.getElementsByClassName(
VIRTUALIZED_CONTAINER_CLASS
)[0] as HTMLDivElement | null;

// re-render data grid on size changes
useResizeObserver(virtualizeContainer);

useEffect(() => {
if (virtualizeContainer?.clientWidth) {
setVirtualizeContainerWidth(virtualizeContainer.clientWidth);
}
}, [virtualizeContainer?.clientWidth]);

useEffect(() => {
// wait for layout to settle, then measuer virtualize container
setTimeout(() => {
if (virtualizeContainer?.clientWidth) {
const containerWidth = virtualizeContainer.clientWidth;
setVirtualizeContainerWidth(containerWidth);
}
}, 100);
}, [pagination?.pageSize, virtualizeContainer]);

const hasRoomForGridControls = IS_JEST_ENVIRONMENT
? true
: gridWidth > minSizeForControls || isFullScreen;
Expand Down Expand Up @@ -801,9 +825,7 @@ export const EuiDataGrid: FunctionComponent<EuiDataGridProps> = (props) => {
const defaultColumnWidth = useDefaultColumnWidth(
// use clientWidth of the virtualization container to take scroll bar into account
// if that's not possible fall back to the size of the wrapper element
(resizeRef?.getElementsByClassName(VIRTUALIZED_CONTAINER_CLASS)[0] as
| HTMLDivElement
| undefined)?.clientWidth || gridDimensions.width,
virtualizeContainerWidth || gridDimensions.width,
leadingControlColumns,
trailingControlColumns,
orderedVisibleColumns
Expand Down
6 changes: 3 additions & 3 deletions src/components/datagrid/data_grid_body.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ const InnerElement: VariableSizeGridProps['innerElementType'] = forwardRef<
InnerElement.displayName = 'EuiDataGridInnerElement';

const INITIAL_ROW_HEIGHT = 34;
const SCROLLBAR_HEIGHT = 15;
const SCROLLBAR_HEIGHT = 16;
const IS_JEST_ENVIRONMENT = global.hasOwnProperty('_isJest');

export const EuiDataGridBody: FunctionComponent<EuiDataGridBodyProps> = (
Expand Down Expand Up @@ -524,10 +524,10 @@ export const EuiDataGridBody: FunctionComponent<EuiDataGridBodyProps> = (
const [height, setHeight] = useState<number | undefined>(undefined);
const [width, setWidth] = useState<number | undefined>(undefined);

// reset height constraint when rowCount changes
// reset height constraint when rowCount or fullscreen setting changes
useEffect(() => {
setHeight(undefined);
}, [rowCount]);
}, [rowCount, isFullScreen]);

const wrapperRef = useRef<HTMLDivElement | null>(null);
const wrapperDimensions = useResizeObserver(wrapperRef.current);
Expand Down